search

ibayer / fastFM-core

A short paper describing the library is available on arXiv.
http://arxiv.org/abs/1505.00641
Other
64 stars 25 forks source link

Bpr fix out of bound error #13

Closed felixmaximilian closed 8 years ago

felixmaximilian commented 8 years ago

Potential fix for https://github.com/ibayer/fastFM/issues/61 (#61). The problem with this while loop is, the following: While p_n is the reason why the conditional OR evaluates to true (even the p_p part is false), i_to_update can decide to update p_p which leads to an infinite loop and the p_p accesses Ax[p_p] on an undefined memory slot.

ibayer commented 8 years ago

@felixmaximilian Thanks for the PR!

I can crash the fitting process by passing just one specific learning pair, but the whole feature matrix. This is the exact learning pair you see in the stack above.

Can you post your one pair breaking example here? I didn't get it from the debug output.

I probability have time tomorrow to have a closer look in order to check if there are related issues.

felixmaximilian commented 8 years ago

You can see the pair in the gdb info locals output in the issue report. It's called sample_row_p and n. But without the data it won't help you understand I think. Unfortunately I cannot post the feature matrix.

ibayer commented 8 years ago

@felixmaximilian The issue you found shows up at more places (see my referenced PR).

ibayer commented 8 years ago

@felixmaximilian Can we close this now?