search

ibayer / fastFM

fastFM: A Library for Factorization Machines
http://ibayer.github.io/fastFM
Other
1.08k stars 204 forks source link

Add manylinux1 build on travis #125

Closed chezou closed 6 years ago

chezou commented 6 years ago

This PR adds building manlinux1 wheels on travis-ci.

This work mostly depends on @chittti 's work https://gist.github.com/chittti/c95de0bd1bab8340c34b59d1be21bb26 https://gist.github.com/chittti/bfa4f4fdc2d8ab9e8be01ce2dd087cce

close https://github.com/ibayer/fastFM/issues/122

ibayer commented 6 years ago

Thanks, having manylinux integrated with travis would be great. :-)

/opt/rh/devtoolset-2/root/usr/libexec/gcc/i386-CentOS-linux/4.8.2/ld: i386:x86-64 architecture of input file `fastFM-core/bin//libfastfm.a(cs_entry_di.o)' is incompatible with i386 output

I think @chittti had issues with i386 too and we decided to only providing 64bit binaries for now.

chezou commented 6 years ago

All right. I've just removed 32bit build with https://github.com/ibayer/fastFM/pull/125/commits/f3a6c5ab842c357165bba5b0d66426172c551e52 .

chezou commented 6 years ago

@ibayer Now CI passed. Could you check the PR?

ibayer commented 6 years ago

@chezou LGTM Is there a way to test if the release upload etc. works? Or do I need to merge on master first and make a new release? I'm okay with this if there is not easy option to test otherwise.

chezou commented 6 years ago

If you push some tagged branch on GitHub like test, I think you can see uploaded files.

ibayer commented 6 years ago

Thanks, I will test it tonight and if it works merge and create a new release. :-)

chezou commented 6 years ago

Ah, sorry. We can’t upload before merging. The test tag is available after merging.