Feature json serialization

ibayer / fastFM

fastFM: A Library for Factorization Machines

http://ibayer.github.io/fastFM

Other

1.08k stars 204 forks source link

Feature json serialization #129

Open AlexJoz opened 6 years ago

AlexJoz commented 6 years ago

We can send the data, but i don't really like the way it happens. Any thoughts?

ibayer commented 6 years ago

What bothers you? The whole to string serialization? Python side looks fine to me.

AlexJoz commented 6 years ago

yep, python side is fine and even jsonify the real settings - easy. But i don't really like the c++ side. And what about precision of float/double types. as text?

ibayer commented 6 years ago

Can you open PR for the cpp stuff, easier to discuss details there.