search

ibayer / fastFM

fastFM: A Library for Factorization Machines
http://ibayer.github.io/fastFM
Other
1.07k stars 206 forks source link

Fixbuild #161

Closed AlexJoz closed 3 years ago

AlexJoz commented 3 years ago

ah, inverted success/failed builds ^^

py version-dependent =(

ibayer commented 3 years ago

@AlexJoz looking at https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/utils/_testing.py#L41 and considering that sklearn has removed testing from it's api we probably should import from numpy directly and hope that this api is more stable.

from numpy.testing import assert_allclose
from numpy.testing import assert_almost_equal
from numpy.testing import assert_approx_equal
from numpy.testing import assert_array_equal
from numpy.testing import assert_array_almost_equal
from numpy.testing import assert_array_less
ibayer commented 3 years ago

@AlexJoz Thanks for fixing our master build. :)