Support sklearn's clone method

ibayer / fastFM

fastFM: A Library for Factorization Machines

http://ibayer.github.io/fastFM

Other

1.07k stars 206 forks source link

Support sklearn's clone method #80

Closed iwiwi closed 7 years ago

iwiwi commented 7 years ago

This PR partially fixes the issue #79. This PR does not fix all the compatibility issues with sklearn API, but, as a starting point, this PR fixes the problem of __init__ methods of the estimators. As confirmed in newly added tests, now all the estimators can be cloned by sklearn.base.clone.

ibayer commented 7 years ago

@iwiwi Thanks for this very useful PR. This closes issue #44 too.