search

ibayer / fastFM

fastFM: A Library for Factorization Machines
http://ibayer.github.io/fastFM
Other
1.07k stars 206 forks source link

Fix the explanation of l2_reg_w and l2_reg_V #81

Closed iwiwi closed 7 years ago

iwiwi commented 7 years ago

I'm not very confident, but I think w and V are linear and pairwise coefficients, respectively, and so, l2_reg_w and l2_reg_V should be penalty weights for linear and pairwise coefficients.

Currently, the explanations of them seem wrongly swapped. This PR proposes to fix them.

ibayer commented 7 years ago

@iwiwi Thanks your are absolutely right. I have somehow the feeling that this issue as been fixed multiple times before :confused: .