[WIP] Drop unnecessary C dependencies - Githubissues

ibayer / fastFM

fastFM: A Library for Factorization Machines

http://ibayer.github.io/fastFM

Other

1.07k stars 206 forks source link

[WIP] Drop unnecessary C dependencies #85

Closed ibayer closed 7 years ago

ibayer commented 7 years ago

Motivation

Dropping all C dependencies from setup.py should make is much simpler to install the fastFM binary and close the following issues: #50 #51 #72 .

Idea

I think the includes in fastFM/setup.py can be reduce to:

      libraries=['fastfm'],
      library_dirs=['fastFM-core/bin/'],
      include_dirs=['fastFM-core/include/']

This requires that all needed C functions are compiled into the static C library fastfm.a that we already include into the python installer.

Milestones

[x] ensure that static versions of blas and cxsparse a properly linked in fastfm.a
[x] drop the unused cs_di_norm() function from cffm.pxd and ffm.pyx.
[x] drop includes and library paths from setup.py

ibayer commented 7 years ago

merged #89