Timer#stop() must behave as #cancel (just for non periodic timers)

ibc / AsyncEngine

Ruby asynchronous event driven framework on top of libuv

6 stars 1 forks source link

Closed ibc closed 12 years ago

ibc commented 12 years ago

Otherwise they could remain in memory forever (user bugs).

Probably the same for periodic timers... so question: what is the benefit of stopping (pausing) a timer???

ibc commented 12 years ago

This stuff has been refactorized:

Timer#cancel has been renamed to Timer#close, and stop is now an alias of close (just for timers).
PeriodicTimer includes the method pause which calls to uv_stop_timer(). This method is not available for non periodic timers.