search

ibc / libsdptransform

Session Description Protocol C++ parser/writer based on the sdp-transform JavaScript library
MIT License
134 stars 56 forks source link

add aes67 tags and test scenario #6

Closed maweit closed 5 years ago

maweit commented 5 years ago

Please add three new sdp tags to grammar.cpp. These are standard tags required for e.g. aes-67 and might be useful for other scenarios as well.

ibc commented 5 years ago

LGTM. Please let me merge it next week (kinda busy this one). Thanks.

ibc commented 5 years ago

Hi, please also add the corresponding documentation in doc/Grammar.md (before the invalid section at the end).

maweit commented 5 years ago

Will do.

ibc commented 5 years ago

Thanks, merged.

ibc commented 5 years ago

I'm afraid test units are not passing. In fact, the a=sync-time reg is too generic (std::regex("\\d")) that it's catching lot of attributes just because those contain ny digit.

Fixing it.

ibc commented 5 years ago

BTW I do not find any reference to a=sync-time. No spec, RFC or draft at all.

ibc commented 5 years ago

This is fixed in b3fe216fc7d7d365d7b602fcb0c876ca89bbf41d. However I need to know where a=sync-time is defined. As said above I cannot find it in any spec. If it's a custom attribute it must be removed and, instead, the app should use the invalid object to write/read it.

maweit commented 5 years ago

Sorry i missed that: sync-time is not standard.

ibc commented 5 years ago

If non standard I'll remove it. I cannot support non standard attributes. You can still use them by filling and reading the media.invalid field.