search

ibecav / CGPfunctions

Powell Miscellaneous Functions for Teaching and Learning Statistics
Other
27 stars 11 forks source link

Typo variablename in vignette #23

Closed paulcbauer closed 4 years ago

paulcbauer commented 4 years ago

Great package! There is a small typo in the vignette: https://cran.r-project.org/web/packages/CGPfunctions/vignettes/Using-newggslopegraph.html

Last chunk it should be "GDP" instead of "rGDP" I think.

ibecav commented 4 years ago

Hi Paul,

Glad you like it. No rGDP is what I'm aiming for. Per the paragraph above...

But the numbers (GDP) are a different matter and there’s no easy way to ensure separation in a case like this data. There’s a decent total spread from 57.4 to 20.7 and some really close measurements like France, Belgium, and Germany on the right side. My suggestion is in a case like this one you create a new column in your dataframe with two significant places. So specifically it would be newgdp$rGDP <- signif(newgdp$GDP, 2). In my testing, at least, I’ve found this helps without creating inaccuracy and not causing you to try and “stretch” vertically to disambiguate the numbers. This time I’ll also use LineColor to highlight how Canada, Finland and Belgium fare from 1970 to 1979.

paulcbauer commented 4 years ago

I quickly copied the chunk for a workshop and didn't read it properly sorry... :-)

On Thu, May 21, 2020 at 3:21 PM Chuck Powell notifications@github.com wrote:

Hi Paul,

Glad you like it. No rGDP is what I'm aiming for. Per the paragraph above...

But the numbers (GDP) are a different matter and there’s no easy way to ensure separation in a case like this data. There’s a decent total spread from 57.4 to 20.7 and some really close measurements like France, Belgium, and Germany on the right side. My suggestion is in a case like this one you create a new column in your dataframe with two significant places. So specifically it would be newgdp$rGDP <- signif(newgdp$GDP, 2). In my testing, at least, I’ve found this helps without creating inaccuracy and not causing you to try and “stretch” vertically to disambiguate the numbers. This time I’ll also use LineColor to highlight how Canada, Finland and Belgium fare from 1970 to 1979.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ibecav/CGPfunctions/issues/23#issuecomment-632082398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB75DJ4XUMNDXUKINBYMRTTRSUTFXANCNFSM4NGY7RNA .

--

Dr. Paul C. Bauer

Mannheim Centre for European Social Research

University of Mannheim

Email: mail@paulcbauer.eu

Current research: "Believing and Sharing Information by Fake Sources https://osf.io/mrxvc" Websites: Homepage http://www.paulcbauer.eu/, GoogleScholar https://scholar.google.ch/citations?user=zRqPQ_kAAAAJ&hl=en&oi=ao, ResearchGate https://www.researchgate.net/profile/Paul_Bauer4, www.tweetingpoliticians.com, SSRN http://papers.ssrn.com/sol3/cf_dev/AbsByAuth.cfm?per_id=1911340, Twitter https://twitter.com/p_c_bauer, Github https://github.com/paulcbauer

The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination, distribution, forwarding, or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited without the express permission of the sender. If you received this communication in error, please contact the sender and delete the material from any computer.

ibecav commented 4 years ago

Laugh out loud, if that's the biggest mistake you made today it's been a great day

paulcbauer commented 4 years ago

Let's hope so ;-)

On Thu, May 21, 2020 at 5:36 PM Chuck Powell notifications@github.com wrote:

Laugh out loud, if that's the biggest mistake you made today it's been a great day

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ibecav/CGPfunctions/issues/23#issuecomment-632160846, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB75DJYMGMJMYEHPY5UTLJDRSVDBLANCNFSM4NGY7RNA .

--

Dr. Paul C. Bauer

Mannheim Centre for European Social Research

University of Mannheim

Email: mail@paulcbauer.eu

Current research: "Believing and Sharing Information by Fake Sources https://osf.io/mrxvc" Websites: Homepage http://www.paulcbauer.eu/, GoogleScholar https://scholar.google.ch/citations?user=zRqPQ_kAAAAJ&hl=en&oi=ao, ResearchGate https://www.researchgate.net/profile/Paul_Bauer4, www.tweetingpoliticians.com, SSRN http://papers.ssrn.com/sol3/cf_dev/AbsByAuth.cfm?per_id=1911340, Twitter https://twitter.com/p_c_bauer, Github https://github.com/paulcbauer

The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination, distribution, forwarding, or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited without the express permission of the sender. If you received this communication in error, please contact the sender and delete the material from any computer.