Open jowr opened 10 years ago
ibell
commented
10 years ago Correct. Can you fix that in the code? And in the docs in CoolProp.pyx?
On Tue, Mar 18, 2014 at 3:12 PM, Jorrit Wronski notifications@github.comwrote:
The SI units for molecular weight should be kg/mol and not g/mol...
Reply to this email directly or view it on GitHubhttps://github.com/ibell/coolprop/issues/187 .
jowr
commented
10 years ago Yes, I already added it to the conversion functions...
jowr
commented
10 years ago Puh, it is used so many places... I think I won't change it any time soon.
ibell
commented
10 years ago I guess the point is that as long as the conversion function is fixed we are good for 4.2, and in v5, everything will be SI. No sense putting more work into the code in 4.2. We should change as little as possible in 4.2.
By the way, are we ready to release 4.2? Can you give me a hand with the release notes?
On 3/18/14, Jorrit Wronski notifications@github.com wrote:
Yes, I already added it to the conversion functions...
From: Ian Bell [notifications@github.com] Sent: 18 March 2014 15:40 To: ibell/coolprop Cc: Jorrit Wronski Subject: Re: [coolprop] Molecular weight (#187)
Correct. Can you fix that in the code? And in the docs in CoolProp.pyx?
On Tue, Mar 18, 2014 at 3:12 PM, Jorrit Wronski notifications@github.comwrote:
The SI units for molecular weight should be kg/mol and not g/mol...
Reply to this email directly or view it on GitHubhttps://github.com/ibell/coolprop/issues/187 .
Reply to this email directly or view it on GitHubhttps://github.com/ibell/coolprop/issues/187#issuecomment-37940078.
Reply to this email directly or view it on GitHub: https://github.com/ibell/coolprop/issues/187#issuecomment-37952322
jowr
commented
10 years ago Yes, no problem.
But can we wait until I finished ExternalMedia?
I currently integrate CoolProp and ExternalMedia and the C++ part is almost done...
On 18/03/14 20:48, Ian Bell wrote:
I guess the point is that as long as the conversion function is fixed we are good for 4.2, and in v5, everything will be SI. No sense putting more work into the code in 4.2. We should change as little as possible in 4.2.
By the way, are we ready to release 4.2? Can you give me a hand with the release notes?
On 3/18/14, Jorrit Wronski notifications@github.com wrote:
Yes, I already added it to the conversion functions...
From: Ian Bell [notifications@github.com] Sent: 18 March 2014 15:40 To: ibell/coolprop Cc: Jorrit Wronski Subject: Re: [coolprop] Molecular weight (#187)
Correct. Can you fix that in the code? And in the docs in CoolProp.pyx?
On Tue, Mar 18, 2014 at 3:12 PM, Jorrit Wronski notifications@github.comwrote:
The SI units for molecular weight should be kg/mol and not g/mol...
Reply to this email directly or view it on GitHubhttps://github.com/ibell/coolprop/issues/187 .
Reply to this email directly or view it on
GitHubhttps://github.com/ibell/coolprop/issues/187#issuecomment-37940078.
Reply to this email directly or view it on GitHub: https://github.com/ibell/coolprop/issues/187#issuecomment-37952322
— Reply to this email directly or view it on GitHub https://github.com/ibell/coolprop/issues/187#issuecomment-37979164.
ibell
commented
10 years ago Sure that's fine by me - theres nothing really pressing in 4.2 except for some problems with conductivty of R134a. I can put some work into the release notes while we wait.
On 3/18/14, Jorrit Wronski notifications@github.com wrote:
Yes, no problem.
But can we wait until I finished ExternalMedia?
I currently integrate CoolProp and ExternalMedia and the C++ part is almost done...
On 18/03/14 20:48, Ian Bell wrote:
I guess the point is that as long as the conversion function is fixed we are good for 4.2, and in v5, everything will be SI. No sense putting more work into the code in 4.2. We should change as little as possible in 4.2.
By the way, are we ready to release 4.2? Can you give me a hand with the release notes?
On 3/18/14, Jorrit Wronski notifications@github.com wrote:
Yes, I already added it to the conversion functions...
From: Ian Bell [notifications@github.com] Sent: 18 March 2014 15:40 To: ibell/coolprop Cc: Jorrit Wronski Subject: Re: [coolprop] Molecular weight (#187)
Correct. Can you fix that in the code? And in the docs in CoolProp.pyx?
On Tue, Mar 18, 2014 at 3:12 PM, Jorrit Wronski notifications@github.comwrote:
The SI units for molecular weight should be kg/mol and not g/mol...
Reply to this email directly or view it on GitHubhttps://github.com/ibell/coolprop/issues/187 .
Reply to this email directly or view it on
GitHubhttps://github.com/ibell/coolprop/issues/187#issuecomment-37940078.
Reply to this email directly or view it on GitHub: https://github.com/ibell/coolprop/issues/187#issuecomment-37952322
Reply to this email directly or view it on GitHub https://github.com/ibell/coolprop/issues/187#issuecomment-37979164.
Reply to this email directly or view it on GitHub: https://github.com/ibell/coolprop/issues/187#issuecomment-37980188
jowr
commented
10 years ago I moved the CPP files for the Modelica wrapper to the ExternalMedia SVN. I guess future changes in ExternalMedia are independent from CoolProp. Hence, we can release 4.2. I'll have a look at the release notes and see if I can add something.
ibell
commented
10 years ago Seems PropsSI still returns mole mass in kg/kmol, I guess either we fix the docs or we fix the output... For 4.2 either is fine by me.
On 3/24/14, Jorrit Wronski notifications@github.com wrote:
I moved the CPP files for the Modelica wrapper to the ExternalMedia SVN. I guess future changes in ExternalMedia are independent from CoolProp. Hence, we can release 4.2. I'll have a look at the release notes and see if I can add something.
Reply to this email directly or view it on GitHub: https://github.com/ibell/coolprop/issues/187#issuecomment-38418880
The SI units for molecular weight should be kg/mol and not g/mol...