search

ibell / pdsim

Steady-State simulation code for positive displacement machines
MIT License
38 stars 23 forks source link

Updated valve model #22

Closed davideziviani closed 7 years ago

davideziviani commented 7 years ago

@ibell Have you seen those updates?

ibell commented 7 years ago

Also, I'm not sure how easy this would be to do, but could you put together a Jupyter notebook that calls the valve model?

davideziviani commented 7 years ago

Certainly I can prepare a notebook on the ValveClass. It will be helpful also for our paper.

ibell commented 7 years ago

Sorry I haven't been following very well things happening in PDSim. I'll review your code tonight.

On Thu, Oct 20, 2016 at 2:21 PM, dziviani notifications@github.com wrote:

@ibell https://github.com/ibell Have you seen those updates?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ibell/pdsim/pull/22#issuecomment-255217030, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxha5GGGS2SssWzZfYeDPZ7yhMyGfJ0ks5q181QgaJpZM4J0P_I .

ibell commented 7 years ago

Can you please make the necessary changes so I can merge this PR?

davideziviani commented 7 years ago

I cleaned the commented lines. It should be good now.