search

ibell / pdsim

Steady-State simulation code for positive displacement machines
MIT License
38 stars 23 forks source link

Modified OBJECTIVE_CYCLE for Multi-Tlumps and plots #26

Closed davideziviani closed 4 years ago

ibell commented 7 years ago

Can you please fix the conflict and I will merge this PR?

davideziviani commented 7 years ago

I should have fixed the conflict. Also I found a small typo.

davideziviani commented 7 years ago

@ibell could you check if now you can merge it? I have another PR to make related to OBJECTIVE_CYCLE as I have integrated an iteration scheme over the rotational speed imposed by a motor (either with map or detailed model)

ibell commented 5 years ago

Have you found a solution for this yet? I would imagine for the recip that this is a serious problem?

davideziviani commented 5 years ago

I am going to push the changes for the solver I wrote to handle both the multi-lump as well as the iteration of the rotational speed of the motor.

davideziviani commented 4 years ago

I am going to send a new PR for this.