search

ibell / pdsim

Steady-State simulation code for positive displacement machines
MIT License
38 stars 23 forks source link

Add user-defined integration upper bound #27

Closed davideziviani closed 6 years ago

davideziviani commented 6 years ago

By default the integration is carried out with crank-angle [0,2pi]. However, the user can define the upper bound as necessary. For example, in twin-screw machines the working cycle is >4pi. Thus, this modification will be useful to implement IntegrableClass.

We could also make the lower bound user defined.

ibell commented 6 years ago

Looks good to me! Thanks, a very good idea that I should have done a long time ago