update syntax wxpython - Githubissues

ibell / pdsim

Steady-State simulation code for positive displacement machines

MIT License

38 stars 23 forks source link

update syntax wxpython #41

Closed davideziviani closed 4 years ago

davideziviani commented 4 years ago

wxpython with py3.6+

davideziviani commented 4 years ago

@ibell : can you look into this PR? I have a few more things to push but I would like to merge this one first.

ibell commented 4 years ago

I checked out the PR, seems to be more or less working. What about the splash screen?

ibell commented 4 years ago

On my side, splash screen doesn't work, but maybe that is a linux issue

davideziviani commented 4 years ago

I am more concerned about the output panel. I can look into the Splash Screen. I am sure I pushed all the changes

ibell commented 4 years ago

Also, on my side, the state chooser is broken (only the first state is visible, pressure is hidden):

ibell commented 4 years ago

Should we merge this one and then try to figure out Output Panel?

davideziviani commented 4 years ago

davideziviani commented 4 years ago

works for me. I am still running py3.6.x, but should not be a problem

ibell commented 4 years ago

So don't worry about state chooser then...

davideziviani commented 4 years ago

Let's merge this one and work on OutputPanel and other issues. The GUI works fine for me on Win.

davideziviani commented 4 years ago

My wxpython version is 4.0.4; I can update to 4.0.7 to see if there are other issues.

ibell commented 4 years ago

Parametric table also broken:

Traceback (most recent call last):
  File "/home/ian/Code/pdsim/GUI/panels/pdsim_panels.py", line 1493, in OnAddTerm
    option = ParametricOption(self, GUI_objects)
  File "/home/ian/Code/pdsim/GUI/panels/pdsim_panels.py", line 1176, in __init__
    labels = [o.annotation for o in GUI_objects.itervalues()]
AttributeError: 'dict' object has no attribute 'itervalues'

ibell commented 4 years ago

k, I'll merge now then, and we can keep working on remaining issues.