search

ibell / pdsim

Steady-State simulation code for positive displacement machines
MIT License
38 stars 25 forks source link

Scroll: sum of spinning moments not zero with ArcLineArc #67

Closed ibell closed 3 years ago

ibell commented 4 years ago

Failing test here: https://github.com/ibell/pdsim/commit/be2565fa08d730ef8b94fab163525bdfb2b786c2

huges84 commented 3 years ago

Does this mean that ArcLineArc should not be used? Does 2Arc pass this test?

ibell commented 3 years ago

2Arc is fine, it is only the ArcLineArc that has the problem. Thanks for the reminder to look back into this subtle point.