ibell / pdsim

Steady-State simulation code for positive displacement machines
MIT License
38 stars 25 forks source link

Screw or scroll expander #72

Open David-Mamrilla opened 2 years ago

David-Mamrilla commented 2 years ago

Hello, I have installed PDSim and am very impressed with the simulation interface for scroll and piston expanders. I would like to kindly ask, does anyone posses models for a scroll or screw expander? I saw that there is a model for a piston expander in the "examples" folder, but I was wondering whether it is possible to implement it with the GUI interface?

Thank you.

ibell commented 2 years ago

Did you check out the models from Paper II?

Yes, it could be implemented, if you wanted to do the work to do so, or if you had funding for me to do it.

On Thu, Feb 17, 2022 at 1:14 PM David-Mamrilla @.***> wrote:

Hello, I have installed PDSim and am very impressed with the simulation interface for scroll and piston expanders. I would like to kindly ask, does anyone posses models for a scroll or screw expander? I saw that there is a model for a piston expander in the "examples" folder, but I was wondering whether it is possible to implement it with the GUI interface?

Thank you.

— Reply to this email directly, view it on GitHub https://github.com/ibell/pdsim/issues/72, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOGC23FWICUR4EV7LYAKKTU3U3KDANCNFSM5OVOZQ2Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

David-Mamrilla commented 2 years ago

Hello, thank you for replying,

Yes, I did check both of the papers. and read carefully especially the part about screw expanders in paper II. However, would it possible to find and use the actual python model? My intent would be to use it for academic purposes only, for my Master thesis on possibilities of PD expanders in steam cycles.

Thank you.

ibell commented 2 years ago

The files are here, but seem to be embargoed: https://figshare.com/articles/code/PDSim_source/7985651. I'll investigate.

On Mon, Feb 21, 2022 at 12:00 PM Dávid Mamrilla @.***> wrote:

Hello, thank you for replying,

Yes, I did check both of the papers. and read carefully especially the part about screw expanders in paper II. However, would it possible to find and use the actual python model? My intent would be to use it for academic purposes only, for my Master thesis on possibilities of PD expanders in steam cycles.

Thank you.

— Reply to this email directly, view it on GitHub https://github.com/ibell/pdsim/issues/72#issuecomment-1047075974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOGC24UND3VWG44WK6DQOTU4JVRLANCNFSM5OVOZQ2Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

David-Mamrilla commented 2 years ago

Thank you :)

ibell commented 2 years ago

Embargo lifted (should have been lifted a long time ago).

Message ID: @.***>

David-Mamrilla commented 2 years ago

Thank you for unlocking the files. Maybe I am not looking in the right folders but I cannot see a screw expander model? It seems that the files on figshare are the same ones as here on Github, with examples of scroll and reciprocating compressors and a piston expander, but no screw. Thank you and sorry if it is in one of the folders and I just didn't see it.

ibell commented 2 years ago

@davideziviani Any idea where the examples went to? I agree they don't seem to be in the figshare repo from paper I

David-Mamrilla commented 2 years ago

Hello, have you by any chance managed to find the examples?

MAKlNE commented 2 years ago

Hello, I can only use Recip compressor and scroll compressor in PDSim app.

Is the Scroll Expander locked?

Kind Regards. Alan

David-Mamrilla commented 2 years ago

No, it is not locked. Only recip and scroll compressor have been implemented in the app. However, there should be python models for other machines, among them the scroll and screw expanders. But it seems the authors can't find them at the moment.