search

iberezansky / flip-book-jquery

3D FlipBook allows to browse images, PDFs or HTMLs as a flipping book. It helps to attract user attention and make more impression on him.
http://3dflipbook.net/
GNU General Public License v2.0
224 stars 86 forks source link

Bug in search term highlight when in first page, and solution #9

Open gstrat88 opened 5 years ago

gstrat88 commented 5 years ago

There is a bug regarding the highlight of a search term in the first page.

It happens because in SearchEngine.prototype.process the page is getting incremented before highlight so page 0 never gets highlighted.

++_this.page; if (_this.onPageHitsChanged) { _this.onPageHitsChanged(_this.page, _this.query); }

the ++_this.page must become _this.page++ and go after the if statement

iberezansky commented 5 years ago

Thank you!

it should be: if (_this.onPageHitsChanged) { _this.onPageHitsChanged(_this.page, _this.query); } ++_this.page;

On Tue, Sep 25, 2018 at 5:39 PM gstrat88 notifications@github.com wrote:

There is a bug regarding the highlight of a search term in the first page.

It happens because in SearchEngine.prototype.process the page is getting incremented before highlight so page 0 never gets highlighted.

++_this.page; if (_this.onPageHitsChanged) { _this.onPageHitsChanged(_this.page, _this.query); }

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iberezansky/flip-book-jquery/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/ARynLGQuEq8o7Vr4p5gdBh-Omb1BTwv-ks5uekA7gaJpZM4W4x-k .

iberezansky commented 3 years ago

Hi there!

We share with you free version of our plugin http://url6652.creators.gumroad.com/ls/click?upn=56j1UXPh1eye3mggAaGeSnpE4V38HBXy4ItD-2BLnkXarMmxp4W7mOEFKPV5gyCc5Bgoph_U31jt5HgHBh7k3Grc5s4l0K-2FUkWcBFr2GoUUlEvgp1YaarNooPQ5zcvhbzIcdIq91W5urTU2UssUFcA9aEcVajiQWX6Jg1fCTMonM0qpfSy-2BD72bqJAOCedEXh1Awxa04Bnkw96L9QBEnpT6m1jb66ljr-2FSzssOqASjgxGH1PIh7oaq7ZmXdkqVCGptlxjDHVivPgUxgWPyv5ivhc1vlYK0S7lHnVs4ePLqJ0iVAKYeRxDbTfpOBRREUNJbLrw6mNzQZ0lGpjyE7bGse9jxzTsdc9QMHClYYTsynXm-2FAXujsEmax-2BLDTQYMBZgkgI3a8ExEKR1rEb-2BGhX-2FXw-2FHVjvo0ye2b7Zq6G2M3In2kIdyOSrPpFBuzipWT49B1B1KfrEc27bMBYHVmBtUyZbxOE34rVUsTqTcfYutlkvB6Lq-2BtyVqar71qDfzaO0HOiwSZtmz2xUms92KXI7oKXjsLy-2B2jGeGJ5fA3JrmR5Y7qHAukPB0S-2BEt8U7ptoAmEtym2LCfB8Ax1HfYJpLZZsYWxkb9sKSZDbkhKdgI1v1l-2BaD8uJxWj-2FewIu-2BKssFUwGjh-2BIeoxhlxAFuR6vrFn35woK9dFwQbqBBBaYgZhMOmLd59ChAji-2B2u2Lnw922rBSLeP6Bc-2BMYpt4QrP31IOwkzQx5w-3D-3D You can use it in any projects!We need your help in promo

Free PDF viewer for Your site

Hi there!

We share with you free version of our plugin http://url6652.creators.gumroad.com/ls/click?upn=56j1UXPh1eye3mggAaGeSuRQrCp2WjB5D1zu-2Bu-2BXtbo-3DxQ0G_U31jt5HgHBh7k3Grc5s4l0K-2FUkWcBFr2GoUUlEvgp1YaarNooPQ5zcvhbzIcdIq91W5urTU2UssUFcA9aEcVajiQWX6Jg1fCTMonM0qpfSy-2BD72bqJAOCedEXh1Awxa04Bnkw96L9QBEnpT6m1jb66ljr-2FSzssOqASjgxGH1PIh7oaq7ZmXdkqVCGptlxjDHVivPgUxgWPyv5ivhc1vlYK0S7lHnVs4ePLqJ0iVAKYeRxDbTfpOBRREUNJbLrw6mNzQZ0lGpjyE7bGse9jxzTsdc9QMHClYYTsynXm-2FAXujsEmax-2BLDTQYMBZgkgI3a8ExEKR1rEb-2BGhX-2FXw-2FHVjvo0ye2b7Zq6G2M3In2kIdyNxhwT0LnzSgLDndL0mqaNOrDDe0LyQO3lrNNqI-2BuztvQmZE1fEE71gdPOmYR1WTU-2BsaRor00aOixsq0eRdDAvcnrq-2BnIwQH16n1wpAbNZkZcCjiXfwC2lznqLrAr0uwn2mUvgLeBeAfevkK3bYtc-2FBoCYvmjdVt95xtG4mby9YceziINdNtnhIz-2BQuVMIe3ZWYbOAUEFthTGFW4RHYZzfJCG4msO64MFxSdSCHRAfHp2CoB9-2Fu1dOOgkQHHdAMBISR-2FtDcQ5oLyFTr7nZjhdW-2ByR7SidIzYRcvT8TgCWWkBw-3D-3D ( http://url6652.creators.gumroad.com/ls/click?upn=56j1UXPh1eye3mggAaGeSnRerDBB5zCpiuClPUH2INFCTNXF7R5SyDMcKTCWj815Eqm6_U31jt5HgHBh7k3Grc5s4l0K-2FUkWcBFr2GoUUlEvgp1YaarNooPQ5zcvhbzIcdIq91W5urTU2UssUFcA9aEcVajiQWX6Jg1fCTMonM0qpfSy-2BD72bqJAOCedEXh1Awxa04Bnkw96L9QBEnpT6m1jb66ljr-2FSzssOqASjgxGH1PIh7oaq7ZmXdkqVCGptlxjDHVivPgUxgWPyv5ivhc1vlYK0S7lHnVs4ePLqJ0iVAKYeRxDbTfpOBRREUNJbLrw6mNzQZ0lGpjyE7bGse9jxzTsdc9QMHClYYTsynXm-2FAXujsEmax-2BLDTQYMBZgkgI3a8ExEKR1rEb-2BGhX-2FXw-2FHVjvo0ye2b7Zq6G2M3In2kIdyMLk39vO6iwKxIV8kQv93-2FX1qsQp5j6UH3pxo3W2g7jNUiN83rXaNVLbSc9khms5kzxpXGRf-2Bfg1gfy51bREOQXoeTFpkFxqzDsxC9q7dj0zGaYM95aWI2i2Hd4hq69IAPU1wo1q4ebGR7StM5jV-2BBgoWhmjeFkAmuOS2I9lNyA-2BIMRjOUPhrykDZ8npCePOXs4kAGBC0AAog-2Bzh4LpF8F-2Bk7W-2FxidyHRdzwitW-2BYsAPv0ZWoE4UoG0m5fXV9nKFbYZuO9uIqXBJP4nUfi6SGGLUzWUraSkYnbm1WyTl-2FuH6g-3D-3D ). You can use it in any projects!

We need your help in promotion, so if you like this, give us thumbs up and subscribe for next campaigns.

All the best,

3D FlipBook Team.

Download ( http://url6652.creators.gumroad.com/ls/click?upn=56j1UXPh1eye3mggAaGeSjLE1bd9VFliUaDFepiiQo8TitmYQFcoyOjtFnZnBes3bp7pElfVyrKllUks-2BLNFKr75BS-2B5GLdnJdaTwQ7fA5QVt5UIIZkbkRGyr5-2BkwKowsqUa_U31jt5HgHBh7k3Grc5s4l0K-2FUkWcBFr2GoUUlEvgp1YaarNooPQ5zcvhbzIcdIq91W5urTU2UssUFcA9aEcVajiQWX6Jg1fCTMonM0qpfSy-2BD72bqJAOCedEXh1Awxa04Bnkw96L9QBEnpT6m1jb66ljr-2FSzssOqASjgxGH1PIh7oaq7ZmXdkqVCGptlxjDHVivPgUxgWPyv5ivhc1vlYK0S7lHnVs4ePLqJ0iVAKYeRxDbTfpOBRREUNJbLrw6mNzQZ0lGpjyE7bGse9jxzTsdc9QMHClYYTsynXm-2FAXujsEmax-2BLDTQYMBZgkgI3a8ExEKR1rEb-2BGhX-2FXw-2FHVjvo0ye2b7Zq6G2M3In2kIdyN-2B3ciOhxWEPDcILoc4OD4pSz-2Fk5ujuFR-2BvoficR2639zhxNAUoiTtr1-2BNgEr-2FDD-2BtP8gfBSI0zZrZQb88-2BzDH1cSSxCv8WAkEuOVR8vkSmNeE7p4-2BOU7dJumufKJT1UhrXRQj7P71ZR1SSXR66ts10VU4-2BEYh5OMJ-2B2bZIsZ2ZzNIanPA4i-2F4hXDf2EVN6LeEHV5eKG-2FW7mTMlQz-2BFKJhlPRL-2BSbkqxORra5Gc2p1z08bKynBdxY-2FXiXsQCMut1bUmrbVEIy8Zs7CTKQ0FHAAtatzSsOlsVsbqGo1i9VNgTQ-3D-3D )

Unsubscribe ( http://url6652.creators.gumroad.com/ls/click?upn=56j1UXPh1eye3mggAaGeShD1-2FlVeyzX2XF4-2BgBMhMrRuo7CAFxb9DH7wmblCnw9mlMVKmwyS4oaqkMJeVhbnvXgwNDBga8ytF614CakKJjc-3DyWxR_U31jt5HgHBh7k3Grc5s4l0K-2FUkWcBFr2GoUUlEvgp1YaarNooPQ5zcvhbzIcdIq91W5urTU2UssUFcA9aEcVajiQWX6Jg1fCTMonM0qpfSy-2BD72bqJAOCedEXh1Awxa04Bnkw96L9QBEnpT6m1jb66ljr-2FSzssOqASjgxGH1PIh7oaq7ZmXdkqVCGptlxjDHVivPgUxgWPyv5ivhc1vlYK0S7lHnVs4ePLqJ0iVAKYeRxDbTfpOBRREUNJbLrw6mNzQZ0lGpjyE7bGse9jxzTsdc9QMHClYYTsynXm-2FAXujsEmax-2BLDTQYMBZgkgI3a8ExEKR1rEb-2BGhX-2FXw-2FHVjvo0ye2b7Zq6G2M3In2kIdyNvpabo7BZOspadyJCi19cxZEu7-2BnnVCcVzfLGrpL99rq5OE8liDVYZBdBj81PU-2B4MuCTZ0mdx9fAzMEs-2F16mu7kBCX6v93rmsYVgy58ede3SltUdtKyoZcg-2F-2FcMICwvlxDm-2Bj5ltxVRtEI-2FOm1-2Bbq3hhSUCixppCkGKVg9jc-2FtwLK4kKXivtuM0IqDgWUKimQ3S-2BOLR289MDzgXBDPmH3PckxIvHax205wnEeWQ7AHECRO70Y-2FOgD-2BEiEIgKJU9mpTs9pOsYWLTUpb3n-2FQ5Q9PY186d7gnuUc-2B1czXmFL2oQ-3D-3D )

548 Market St, San Francisco, CA 94104-5401, USA