search

ibericode / vat

PHP library for dealing with European VAT
https://packagist.org/packages/ibericode/vat
MIT License
425 stars 61 forks source link

Update 1.x patterns to match latest 2.x #66

Closed lukeholder closed 5 months ago

lukeholder commented 5 months ago

For backward compatibility reasons, our customers can't use the latest 2.x release until our next major release, so we need to keep using your 1.x version in our application. But, we still want to keep the VAT ID pattern matching up to date, so this PR updated the patterns in 1.x with the up-to-date patterns found in the main branch.

Could this repo please add a 1.x- named branch so we can make PRs to it and you possibly continue to tag 1.x releases from it?

I will switch this PR's base repository once the 1.x branch is created.

If you are unwilling, we will have to go down the path of maintaining a fork.

Thanks 🙏🏻

dannyvankooten commented 5 months ago

Hello @lukeholder,

Branch 1.x was created with your merge request merged and some other quick fixes to get it in a state we can work from. I'm not eager for too much work on this branch (obviously), but anything simple I'm down for. :+1:

Do you have anything else you'd like included in a soon-ish release or are we good to tag 1.2.2?

https://github.com/ibericode/vat/tree/1.x

lukeholder commented 5 months ago

@dannyvankooten fantastic!! Releasing a 1.2.2 would be great!

I am happy to maintain the 1.x version for the next year or so until we can upgrade. Thanks!

lukeholder commented 5 months ago

@dannyvankooten can you cut the 1.2.2 please 🙏🏻

dannyvankooten commented 5 months ago

Hello @lukeholder,

Whoops, sorry. Did it just now!

lukeholder commented 5 months ago

@dannyvankooten thanks!