search

ibesora / vt-optimizer

A small NodeJS cli tool to inspect and optimize Mapbox Vector Tiles files
MIT License
65 stars 12 forks source link

Problems with the visibility check #13

Closed ibesora closed 2 years ago

ibesora commented 2 years ago

@ibesora I'm still having problems with the visibility check. It looks like later uses of a layer overwrite earlier ones resulting in removing to much source layers.

Originally posted by @indus in https://github.com/ibesora/vt-optimizer/issues/12#issuecomment-1025648314

ibesora commented 2 years ago

@indus , I'll take a look at it later this week. Can you provide a repro example? Thanks!

indus commented 2 years ago

@ibesora I have made a repo that shows the problems. https://github.com/indus/-vt-optimizer_issue13

I produced a tiny mbtiles file with only a single point for z0-4 in it. Then there are 3 styles that should get used for optimization. When a layer is only used a single time I get correct results, but not when I use a layer in the mbtiles files more then once in the stylesheet: https://github.com/indus/-vt-optimizer_issue13/blob/main/style.json You can find the results directly in the README but I have also included the the (incorrect) optimized mbtiles.

ibesora commented 2 years ago

This should be fixed with https://github.com/ibesora/vt-optimizer/commit/b13107dcd4e15d9a18c7444ddf1efc986a457e00 @indus Thank you very much for your awesome repo. As you said, when multiple layers were using the same source-layer, it was getting overwritten

indus commented 2 years ago

I have to thank you :-)Am 05.02.2022 20:03 schrieb Isaac Besora Vilardaga @.***>: This shoudl be fixed with b13107d @indus Thank you very much for your awesome repo. As you said, when multiple layers were using the same source-layer, it was getting overwritten

—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: @.***>