ibhagwan / fzf-lua

Improved fzf.vim written in lua
MIT License
2.29k stars 149 forks source link

`git_stage_unstage` doesn't stage or unstage #1004

Closed heygarrett closed 9 months ago

heygarrett commented 9 months ago

Info

NVIM v0.9.5
Build type: Release
LuaJIT 2.1.1703358377

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/opt/homebrew/Cellar/neovim/0.9.5/share/nvim"

Run :checkhealth for more info
fzf-lua configuration ```lua return { "https://github.com/ibhagwan/fzf-lua", config = function() local fzf_lua = require("fzf-lua") local actions = require("fzf-lua.actions") vim.api.nvim_create_user_command( "Status", function() fzf_lua.git_status() end, { desc = "fzf-lua picker: git status" } ) fzf_lua.setup({ fzf_opts = { ["--cycle"] = "", }, winopts = { preview = { layout = "vertical", vertical = "down:75%", }, }, git = { status = { cmd = "git status --short", actions = { ["right"] = false, ["left"] = false, ["tab"] = { fn = actions.git_stage_unstage, reload = true, }, }, }, }, }) end, } ```

Description

I've noticed recently that using git_stage_unstage has stopped working. I tried changing it to a different keymap, but no luck. I also tried re-enabling right and left default keymaps and confirmed git_stage and git_unstage still work as expected.

I struggled to figure out how to customize the minimal init, so apologies for not being able to reproduce the issue that way.

ibhagwan commented 9 months ago

@heygarrett, correct, oversight of a recent PR (#991+https://github.com/ibhagwan/fzf-lua/commit/cc47997ebeb87e0caa9ab6fd8039427c1f6930ee), should work after https://github.com/ibhagwan/fzf-lua/commit/f021b287bf095f20cb5062fc9486dd3243ae220c.

heygarrett commented 9 months ago

Yep! It's working now. Thanks!