search

ibhagwan / fzf-lua

Improved fzf.vim written in lua
GNU Affero General Public License v3.0
2.15k stars 141 forks source link

Broken select behavior when using with "Shatur/neovim-session-manager" #1014

Closed lmquansgt closed 7 months ago

lmquansgt commented 7 months ago

Info

fzf-lua configuration ```lua require('fzf-lua').setup() ```

Description

When opening SessionManager load_session command and exiting select ui without choosing any option with Esc wil result in subsequent SessionManager load_session commands to not trigger ui select.

https://github.com/ibhagwan/fzf-lua/assets/130047938/2e64b907-a763-43b7-936b-fb099967a27f

ibhagwan commented 7 months ago
lmquansgt commented 7 months ago

Does the same happen with the default vim.ui.select? I.e. never running :FzfLua register_ui_select?

It seems to only happen when FzfLua isn't registered to ui select

If you do not select a session, then run :FzfLua deregister_ui_select and try to load another session (using the default UI), will it open the UI again if you run load_session?

After I run :FzfLua register_ui_select the UI is working normally again.

lmquansgt commented 7 months ago

Turn out I got another plugin "stevearc/dressing.nvim" which register select ui automatically without calling :FzfLua register_ui_select which probably was the cause.

lmquansgt commented 7 months ago

It seems I really misconfigured dressing. Sorry for the trouble

ibhagwan commented 7 months ago

Ty for the update @lmquansgt

ibhagwan commented 7 months ago

@lmquansgt, FYI, https://github.com/ibhagwan/fzf-lua/commit/5474df3a722b0efbeb9f47d0b2fdbce7d2ff258e and the latest dressing.nvim changes makes the plugins play better, I have a feeling might help your orignal issue as well.

lmquansgt commented 7 months ago

@ibhagwan Thank for the heads up. I tried it out again and now it work perfectly without the need to call register_ui_select explicitly. :+1: