Closed landonreed closed 5 years ago
Comment by codecov-io Wednesday Sep 05, 2018 at 19:34 GMT
Merging #115 into dev will increase coverage by
0.73%
. The diff coverage is76.66%
.
@@ Coverage Diff @@
## dev #115 +/- ##
==========================================
+ Coverage 4.41% 5.15% +0.73%
- Complexity 78 94 +16
==========================================
Files 132 133 +1
Lines 7017 7079 +62
Branches 917 925 +8
==========================================
+ Hits 310 365 +55
- Misses 6688 6689 +1
- Partials 19 25 +6
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...va/com/conveyal/datatools/manager/DataManager.java | 58.2% <72.72%> (+6.1%) |
30 <1> (+4) |
:arrow_up: |
...ols/manager/controllers/api/AppInfoController.java | 87.5% <87.5%> (ø) |
3 <3> (?) |
|
...atatools/editor/jobs/ProcessGtfsSnapshotMerge.java | 0% <0%> (ø) |
0% <0%> (ø) |
:arrow_down: |
...com/conveyal/datatools/editor/models/Snapshot.java | 0% <0%> (ø) |
0% <0%> (ø) |
:arrow_down: |
...datatools/editor/jobs/ConvertEditorMapDBToSQL.java | 0% <0%> (ø) |
0% <0%> (ø) |
:arrow_down: |
...m/conveyal/datatools/manager/jobs/FeedUpdater.java | 0% <0%> (ø) |
0% <0%> (ø) |
:arrow_down: |
...tools/editor/controllers/api/EditorController.java | 0% <0%> (ø) |
0% <0%> (ø) |
:arrow_down: |
...tools/editor/controllers/EditorLockController.java | 0% <0%> (ø) |
0% <0%> (ø) |
:arrow_down: |
.../conveyal/datatools/editor/utils/DirectoryZip.java | 0% <0%> (ø) |
0% <0%> (ø) |
:arrow_down: |
...com/conveyal/datatools/manager/jobs/DeployJob.java | 0% <0%> (ø) |
0% <0%> (ø) |
:arrow_down: |
... and 6 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8b83f71...bad70e6. Read the comment docs.
Comment by landonreed Wednesday Sep 19, 2018 at 21:11 GMT
@evansiroky, I'm currently working on some changes that create CRUD methods for the OtpServer class and now realizing that the name ServerController
might be too similar to whatever we call the controller class for OtpServer. Could you refactor the name ServerController
-> AppInfoController
(or some other you deem appropriate). Some referencing comments and the test class name will need updating, too. Following that, let's merge this in.
Issue by evansiroky Wednesday Sep 05, 2018 at 19:27 GMT Originally opened as https://github.com/catalogueglobal/datatools-server/pull/115
Add a new api endpoint that provides useful information such as the repository URL and the git commit associated with the application.
evansiroky included the following code: https://github.com/catalogueglobal/datatools-server/pull/115/commits