Shared Stops Validator: Validate `feed_id`

ibi-group / datatools-server

Server for IBI's GTFS data management platform.

MIT License

49 stars 51 forks source link

Shared Stops Validator: Validate `feed_id` #557

Closed miles-grant-ibigroup closed 11 months ago

miles-grant-ibigroup commented 1 year ago

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing

Description

Builds on #552, only validating the shared stop if the feed_id of the feed matches the feed id of the row being validated

miles-grant-ibigroup commented 12 months ago

I don't really see an alternative to using JDBCFetcher (this is the first use of it in DT). I guess the validation cannot be done in GTFS lib because you need the project's shared stop config and this transcends all feed versions so it can't be included there?

Yeah we'd do all the validation in gtfs-lib but we don't have access to the feed info table in there

br648 commented 12 months ago

I don't really see an alternative to using JDBCFetcher (this is the first use of it in DT). I guess the validation cannot be done in GTFS lib because you need the project's shared stop config and this transcends all feed versions so it can't be included there?

Yeah we'd do all the validation in gtfs-lib but we don't have access to the feed info table in there

Feed Info is loaded by GTFS-Lib it's just not made available in Feed. This could be updated to include feed info. But if I understand this correctly, GTFS Lib doesn't have the shard stop config so you'd still have a similar issue?