support new `Url` config fields

[miles-grant-ibigroup]

Checklist

• [x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
• [x] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
• [x] The description lists all applicable issues this PR seeks to resolve
• [x] The description lists any configuration setting(s) that differ from the default settings
• [x] All tests and CI builds passing
• [ ] The description lists all relevant PRs included in this release (remove this if not merging to master)
• [x] e2e tests are all passing (remove this if not merging to master)

Description

Adds 2 new fields to Deployment that allow for downloading the router/build config from a URL. If the URL field is present, the old field is ignored, and a new file downloaded instead. Downloaded file is parsed only by Java's bulit-in toString method, so safety-wise we should be ok.

Looking for feedback

Should mongo be updated when we download the data? Are errors handled well? How should we test this?

[br648]

@miles-grant-ibigroup I've made a few code changes, quicker than going back and forth through comments. I hope you don't mind.

I've added a test, it might not be what you are looking for, but will at least test that the download from URL works.

I'm not sure on saving to Mongo. How often will the downloaded config change and how often will it be download?! If you save the config to Mongo, you then have to deal with the logic around downloading a newer config. We can discuss this if you want?

[miles-grant-ibigroup]

@miles-grant-ibigroup I've made a few code changes, quicker than going back and forth through comments. I hope you don't mind.

I've added a test, it might not be what you are looking for, but will at least test that the download from URL works.

I'm not sure on saving to Mongo. How often will the downloaded config change and how often will it be download?! If you save the config to Mongo, you then have to deal with the logic around downloading a newer config. We can discuss this if you want?

Thanks for your refactor I for the most part much prefer it! However, does this take into account that if no URL is set the buildConfig/routerConfig from Mongo should be used?

[br648]

@miles-grant-ibigroup I've made a few code changes, quicker than going back and forth through comments. I hope you don't mind. I've added a test, it might not be what you are looking for, but will at least test that the download from URL works. I'm not sure on saving to Mongo. How often will the downloaded config change and how often will it be download?! If you save the config to Mongo, you then have to deal with the logic around downloading a newer config. We can discuss this if you want?

Thanks for your refactor I for the most part much prefer it! However, does this take into account that if no URL is set the buildConfig/routerConfig from Mongo should be used?

I've made a small change to only assign the downloaded config if available.

[miles-grant-ibigroup]

@miles-grant-ibigroup I've made a few code changes, quicker than going back and forth through comments. I hope you don't mind. I've added a test, it might not be what you are looking for, but will at least test that the download from URL works. I'm not sure on saving to Mongo. How often will the downloaded config change and how often will it be download?! If you save the config to Mongo, you then have to deal with the logic around downloading a newer config. We can discuss this if you want?

Thanks for your refactor I for the most part much prefer it! However, does this take into account that if no URL is set the buildConfig/routerConfig from Mongo should be used?

I've made a small change to only assign the downloaded config if available.

This looks great thanks so much! Things are working for me but would appreciate if someone else gave it a quick check too to make sure it still works

[philip-cline]

I can give it a quick check