Trip Pattern editor: click to add control point doesn't add control point

[landonreed]

Issue by skinkie Thursday Jul 12, 2018 at 08:13 GMT Originally opened as https://github.com/catalogueglobal/datatools-ui/issues/213

---

[landonreed]

Comment by landonreed Thursday Jul 12, 2018 at 13:10 GMT

---

Ah, the label in the tooltip actually needs to be modified. First, a segment of the pattern must be clicked to highlight it (in green). Then, the segment can be clicked to add a control point.

[landonreed]

Comment by skinkie Thursday Jul 12, 2018 at 13:15 GMT

---

I can make it green. But what would now create the control point?

[landonreed]

Comment by landonreed Thursday Jul 12, 2018 at 13:17 GMT

---

In this case the dashed line indicates that there is no shape defined yet. You must click the Edit Pattern Geometry > Stops button to generate the shape from existing stops. The pattern shape panel is in need of a refactor to make conditions like this clearer.

On Thu, Jul 12, 2018 at 9:15 AM Stefan de Konink notifications@github.com wrote:

[image: image] https://user-images.githubusercontent.com/502394/42635412-4b039de0-85e6-11e8-9f08-6fbb20623481.png

I can make it green. But what would now create the control point?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/catalogueglobal/datatools-ui/issues/213#issuecomment-404508001, or mute the thread https://github.com/notifications/unsubscribe-auth/ACQtX3J0lAU7iGcWuYgUZQZKKp_Cw9kiks5uF0vXgaJpZM4VMZdi .

-- Landon Reed Project Lead, Conveyal http://conveyal.com (+1) 404 245 0597 lreed@conveyal.com

[landonreed]

Comment by skinkie Thursday Jul 12, 2018 at 13:20 GMT

---

Thanks; that works. The scary message that it would overwrite the trip pattern should also be removed. It would overwrite the route (transmode) / shape (gtfs) but not the already defined stops in journey pattern (transmodel).

[landonreed]

Comment by landonreed Thursday Jul 12, 2018 at 13:22 GMT

---

Good point, that message could be clarified and does not even need to appear if there is no shape to begin with.

[landonreed]

Comment by skinkie Thursday Jul 12, 2018 at 13:43 GMT

---

@landonreed after I deployed this feed, and tried to edit it. The shape is not available anymore, and the stops button return into an error.

[landonreed]

Comment by simonsouth Thursday Nov 22, 2018 at 08:45 GMT

---

You must click the Edit Pattern Geometry > Stops button to generate the shape from existing stops.

In my case, doing this and clicking through the first error message produces a second:

Clicking "Close" leaves everything unchanged and the route's shape remains un-editable.

Is it not yet possible to edit shapes, even manually, if a stop is not reachable from the road network?

[landonreed]

Comment by simonsouth Thursday Nov 22, 2018 at 09:36 GMT

---

Is it not yet possible to edit shapes, even manually, if a stop is not reachable from the road network?

It is: The issue in my case was a missing API key for GraphHopper, the routing service that replaced Mapzen (see issue #60). With the key added to env.yml routing between stops is working normally for me.