ibi-group / trimet-mod-otp

5 stars 5 forks source link

Shared Use Modes: Functionality of links to service providers #96

Closed msrichardson closed 5 years ago

msrichardson commented 6 years ago

Uber Desktop: When planning a trip including Uber on the desktop, unlike in the mobile version, if the user clicks on the Book Ride button, it takes them to this page, which presumes you don't have an account. It should really direct the user to this page.

Further, it would be preferable if a new browser tab was opened when Book Ride is clicked on the desktop version (currently, it replaces the trip planner in the same tab).

Mobile: The mobile version works as expected.

Lyft Mobile: When planning a trip using the mobile version, the origin is passed along correctly, but not the destination. It asks the user to resubmit the destination.

Desktop: When planning a trip using the desktop version, the Book Ride link took one to the sign-in page, but then after signing in, a Bad Request page resulted (see below).

croppercapture 272 (url for page: https://ride.lyft.com/u?id=lyft&partner=undefined&pickup[latitude]=45.525967&pickup[longitude]=-122.804555&destination[latitude]=45.55661213242548&destination[longitude]=-122.81485258341843)

msrichardson commented 6 years ago

Lyft update Desktop is now working, thanks. Mobile is mostly working as expected, although there is a brief moment where it asks for your destination, before redirecting (see video). Is there anything on our end that could be done to rectify this? [This aspect is a Medium priority]

lyft_mobile

msrichardson commented 6 years ago

Uber update When accessing via the desktop, it now asks you to log into your account, but then displays page below, with no sign of the trip plan. [comment continues below screenshot]

image

Also, now on the mobile version, it is consistently using the user's NE Portland location for the origin on egress legs, rather than the itinerary location (see video). [Both Uber items are high priority]

uber_mobile

landonreed commented 6 years ago

@msrichardson, I'm having trouble recreating the location/origin issue on my Android. Could you confirm that this is still happening? If so, would it be possible for you to come up with a list of steps to reproduce it on your device (e.g., open trip planner, set destination to X, set origin to Y, click Plan Trip, select itinerary, open Uber link). It's possible that this could also be an iPhone only issue since I'm not encountering it.

msrichardson commented 6 years ago

@landonreed It could be an iPhone only issue. I don't have an Uber account, so am unable to test myself, but will see if I can find someone to verify.

msrichardson commented 6 years ago

@landonreed I just downloaded Uber on my Android, and found the same as you. Thus, I believe the location/origin issue is isolated to iPhones.

landonreed commented 6 years ago

@msrichardson, we just got a hold of an iOS device and were still not able to reproduce the issue. Were you able to verify with an iPhone user that the issue still exists for them?

msrichardson commented 6 years ago

@landonreed Verified still exists (can provide gif if needed).

landonreed commented 6 years ago

Ok, thanks. Yes, if you could capture all of the steps to recreate it (in text or gif form), that would be helpful because I cannot reproduce on my iOS device.

msrichardson commented 6 years ago

@landonreed iPhone 7, iOS 12.0, Safari

uber_mobile_20181003

landonreed commented 6 years ago

Ah, one more thing: do you know what version of the Uber app is installed?

msrichardson commented 6 years ago

Version 3.319.10003

landonreed commented 6 years ago

OK, I can confirm that I can now reproduce this. It looks like the user's current location is replacing the origin for the Uber trip right after the app opens up, but this only appears to happen if the Uber app is starting up for the first time. In other words, if you try the Book Ride link, switch back to the trip planner website (without closing the Uber app), and the re-try Book Ride then you should get the desired result.

This is even more apparent when the user's location is in Atlanta (screen capture: https://photos.app.goo.gl/8cACuKEUxZSDKXkS6).

I'm not sure why the Uber app is replacing the origin with the user's current location. This could be a bug with Uber.

landonreed commented 6 years ago

It's unclear if there's a better support venue than Stack Overflow, but I've asked a question there: https://stackoverflow.com/questions/52652989/is-setting-pickup-lat-lon-for-a-ride-request-setpickup-action-via-universal-link

msrichardson commented 5 years ago

@landonreed Any updates on this one (specifically Uber replacing the origin with user's current location)?

msrichardson commented 5 years ago

Uber has fixed a bug on their side. Issue resolved.