ibillingsley / HumbleNewTabPage

New tab page extension for Chrome and Firefox
https://chrome.google.com/webstore/detail/mfgdmpfihlmdekaclngibpjhdebndhdj
MIT License
650 stars 103 forks source link

[Feature request] Store favicons locally #104

Open danielmmmm opened 2 years ago

danielmmmm commented 2 years ago

Instead of downloading icons from providers every time the browser is restarted, favicons should be stored locally. In addition, favicons could be retrieved from several providers to increase the likelihood to get a favicon for every bookmark. As of today, DuckDuckGo is the best provider for my bookmarks. But it (and Google) fails to get a favicon for ice.no. Caching favicons would also reduce traffic for favicon providers. (Apart from that, I love HNTP 😁)

GeniusBroccoli commented 1 year ago

Yea, please, can you implement this? :pleading_face: I have configured the page to show quite a lot of sites in multiple columns. The icons load every time I open the homepage, which is slow and, I think, not very good and could be considered by the icon service as an abuse?

ibillingsley commented 1 year ago

I wish Firefox would implement the favicon api https://bugzilla.mozilla.org/show_bug.cgi?id=1315616

I'm not sure why it redownloads them every time you restart the browser (unless you enabled "Delete cookies and site data when Firefox is closed").

The standard HTTP cache durations are set as follows (I can't control this): Provider max-age
Favicon.ico varies
DuckDuckGo 30 days
Google 7 days
Favicon Kit 1 year
Qwant 14 days
Yandex 8 days

It might be possible to cache them manually with a serviceworker but it's tricky. I'll look in to it.