ibillingsley / HumbleNewTabPage

New tab page extension for Chrome and Firefox
https://chrome.google.com/webstore/detail/mfgdmpfihlmdekaclngibpjhdebndhdj
MIT License
626 stars 104 forks source link

Version 1.25 Broke Opera #110

Open karimhb opened 1 year ago

karimhb commented 1 year ago

I have been using the Chrome extension on Opera for 5 years without a problem. V 1.25 made the extension not have permission to favicons. Unlike other extensions chrome://favicons/* isn't listed under HumbleNewTabPage permissions. favicons don't show up anymore!

noicon

hntp

other extensions work

ibillingsley commented 1 year ago

Manifest V3 introduced a new favicon API starting with Chromium version 104. The latest Opera is based on Chromium 110 so it should work in theory, but it does indeed seem broken. The previous favicon API is no longer available with Manifest V3, so I cannot support both at the same time.

Hopefully Opera fixes this in a future update. ~Until then, you can still download the previous version of Humble New Tab Page at https://github.com/ibillingsley/HumbleNewTabPage/releases/download/1.24/HumbleNewTabPage.1.24.crx Then drag-and-drop the file onto the opera://extensions page to install it. You will need to remove version 1.25 first (be sure to backup your settings as they will be lost).~

Edit: Hmm actually it will still be automatically updated to 1.25. Let me see if I can upload the previous version to addons.opera.com

karimhb commented 1 year ago

Thanks for your reply @ibillingsley. I cloned an older commit and loaded it as an unpacked extension. Works fine!

I understand that you had to support Manifest V3. Not sure how Quick Bookmarks Menu chrome extension supports favicon on both (see my screenshot above).

My issue is fixed. I am all good but you could perhaps support both with some conditional logic.

Thank you.

Edit: I'll keep loading the old version if it reverts to 1.25 until you or opera sort it out. Thanks mate.

degreeze commented 1 year ago

While we wait for Opera to fix it, I decided to stay on the last version and change fav icons to bullet point emoji via custom css.

#main img {
  line-height: 1.0;
}
#main img::before {
  content: '\2022';
}

Maybe someone find it useful too.

And thanks for the awesome extension! Seriously, can't live without it now!

ibillingsley commented 1 year ago

Opera still hasn't reviewed my upload of 1.24.

In the meantime I added a release of version 1.24 that does not auto-update to 1.25: https://github.com/ibillingsley/HumbleNewTabPage/releases/download/1.24/HumbleNewTabPage.1.24-no-update.crx

You can install it by dragging the file onto the opera://extensions page. Note settings will not be shared with the normal version.