search

ibillingsley / HumbleNewTabPage

New tab page extension for Chrome and Firefox
https://chrome.google.com/webstore/detail/mfgdmpfihlmdekaclngibpjhdebndhdj
MIT License
626 stars 104 forks source link

Theme switching #93

Open Brocman opened 3 years ago

Brocman commented 3 years ago

Please implement automatic theme switching when night mode macOS.

dee-me-tree-or-love commented 1 year ago

This is a nice idea, I had the same feeling as @Brocman. @ibillingsley, I'm not sure I will get the time for this, but I might give it a try in the coming time. Are you currently accepting PRs?

ibillingsley commented 1 year ago

I'm not currently accepting PRs because I am planning a rewrite for manifest V3 once it becomes mandatory.

It would be simple enough to change the default theme based on light/dark mode, but to properly support switching we would need to save 2 separate theme configs, since they are customizable.

Also requested in #103

astrocaat commented 7 months ago

hey @ibillingsley, do you have any updates on this now that you took care of manifest V3?

dee-me-tree-or-love commented 7 months ago

@ibillingsley @astrocaat @Brocman, I've started making a fork and got some basic solution running. I'll open a draft PR soon and hope to return to it sometime next week as I find the time :) Hope that's still interesting?

Here's the first impression:

screen-recording-theme-switching

Suggestions and improvements are of course welcome, I'll ping you in the draft PR soon too. :v:

[!NOTE] UPDATE: here's the PR: #116 will be grateful for the review! :-)