search

ibis-project / ibis-analytics

Ibis analytics, with Ibis (and more!)
https://ibis-project.github.io/ibis-analytics
MIT License
19 stars 8 forks source link

move to PyGithub probably #39

Closed lostmygithubaccount closed 6 months ago

lostmygithubaccount commented 9 months ago

I didn't know this existed (despite looking for a GH Python client several times...), but this looks like it could be used: https://pygithub.readthedocs.io/en/stable/introduction.html

however w/ initial testing, it seems more difficult to extract information out of and might not support GraphQL things we'd want

lostmygithubaccount commented 9 months ago

apparently it does have some GraphQL stuff as of relatively recently -- if we can switch to this it seems better than YOLO-ing w/ raw REST/GraphQL API calls to GitHub

simkimsia commented 6 months ago

Pygithub was (is?) slow to incorporate PR

I have made a PR to fix certain issues and it sat for ages before getting merged

https://github.com/PyGithub/PyGithub/pull/2090#issuecomment-1039763286

What's the motivation to use pygithub?

lostmygithubaccount commented 6 months ago

What's the motivation to use pygithub?

the main motivation is I don't really like working with GraphQL/GitHub's GraphQL API -- it's hard to get things working and change them. right now, this project is just ending HTTP requests to Github's REST and GraphQL API -- the GraphQL queries are defined here as strings: https://github.com/ibis-project/ibis-analytics/blob/main/dag/graphql_queries.py

I was hoping PyGithub would be a good Python client wrapping these APIs that I could use to get all the same information, but when I did some evaluation it didn't seem to cover all of the things we needed. I'm just going to close this out -- while it might not be the cleanest, the current method works and has been working just fine for many many months now