Closed gtauzin closed 2 months ago
Attention: Patch coverage is 35.29412%
with 22 lines
in your changes missing coverage. Please review.
Project coverage is 84.08%. Comparing base (
80881f8
) to head (e2f99c6
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
ibis_ml/estimators.py | 33.33% | 22 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closing as @jcrist made it clear that having Steps
as sklean transformer would not be a good idea in #135 .
Following discussion in #135, I thought I would give it a try and set up a wrapper of IbisML steps as fully-fledged sklearn transformers so that they follow more closely the sklearn API.
Running the adapted example notebook, you can already check that :
I'll edit this msg later with a list of more detailed points.