search

ibis-project / ibis-ml

IbisML is a library for building scalable ML pipelines using Ibis.
https://ibis-project.github.io/ibis-ml/
Apache License 2.0
96 stars 13 forks source link

fix(steps): fix `min_frequency` and `max_category` #156

Closed jitingxu1 closed 2 months ago

jitingxu1 commented 2 months ago

changes:

  1. make min_frequence works
  2. select the top category by its frequence when max_categories is specified
  3. increased unit test coverage

solve #146

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.37%. Comparing base (2f2aaaf) to head (77d35d4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #156 +/- ## ========================================== + Coverage 84.94% 85.37% +0.43% ========================================== Files 26 26 Lines 1920 1922 +2 ========================================== + Hits 1631 1641 +10 + Misses 289 281 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

deepyaman commented 2 months ago

Looks great! :shipit: