search

ibis-project / ibis-ml

IbisML is a library for building scalable ML pipelines using Ibis.
https://ibis-project.github.io/ibis-ml/
Apache License 2.0
96 stars 13 forks source link

feat(core): implement a more robust `set_params()` #162

Closed deepyaman closed 2 months ago

deepyaman commented 2 months ago

Related to #135 and #136

Before this PR, it wasn't possible to call set_params() on Step objects, and Recipe.set_params() only trivially set the steps param. With this PR, you can actually set the parameters listed by Recipe.get_params() (and Step.get_params()), which is more robust and akin to scikit-learn.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.70%. Comparing base (cfd6dc1) to head (effadce).

Files with missing lines Patch % Lines
ibis_ml/core.py 94.28% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #162 +/- ## ========================================== + Coverage 87.37% 88.70% +1.32% ========================================== Files 27 27 Lines 1964 2009 +45 ========================================== + Hits 1716 1782 +66 + Misses 248 227 -21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.