search

ibis-project / ibis

the portable Python dataframe library
https://ibis-project.org
Apache License 2.0
4.36k stars 540 forks source link

RLS: 1.3 #2028

Closed jreback closed 4 years ago

jreback commented 4 years ago

we should do a release soon, as last was in mid-summer.

anyone interested in being release manager? also an opportunity to update docs on how-to-release.

xmnlab commented 4 years ago

I am interested :)

xmnlab commented 4 years ago

not sure if it is helpful but maybe it could give us an idea for our own guideline https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide

is there already an estimate date for the release?

jreback commented 4 years ago

we should be able to release any time

if you want to see what is needed great

i wouldn’t reference the arrow release guidelines they are much different / complicated

xmnlab commented 4 years ago

ok sounds good! do you have any other reference you think could be similar that could be similar to ibis?

jreback commented 4 years ago

https://github.com/pandas-dev/pandas/wiki/Release-Checklist

is a bit out of date and ibis doesn’t need to do a lot of this (no need for wheels)

iirc there is already a release checklist

jreback commented 4 years ago

better is here: https://github.com/pandas-dev/pandas-release

xmnlab commented 4 years ago

Aswesome. Thanks I will check that out

xmnlab commented 4 years ago

does make sense for ibis to have also a repo for release like pandas?

xmnlab commented 4 years ago

maybe we can use rever (https://regro.github.io/rever-docs/) it seems it is a very nice tool for software release

jreback commented 4 years ago

before trying to reinvent the wheel

look at how the previous releases were done; i am sure there are docs / wiki

i is has been released many times and @cpcloud likely wrote it down

xmnlab commented 4 years ago

mm you're right ... there is a wiki about that https://github.com/ibis-project/ibis/wiki/Releasing-Ibis

xmnlab commented 4 years ago

maybe we can define a date for the release (Nov, 21st, sounds good?) and we can try to fix #2027 and maybe finish some PR that depends on this fix.

how does it sound?

scottcode commented 4 years ago

Good call on not re-inventing the wheel.

At the least we need to fix #2027. Anything else would be icing on the cake.

xmnlab commented 4 years ago

would be good to add a deprecation warning when it is running on python 3.5? (https://github.com/ibis-project/ibis/issues/1911)

jreback commented 4 years ago

it would be fine also to remove 3.5 for this release

most other packages have dropped it already or next release will as 3.6-3.8 is common

xmnlab commented 4 years ago

Sounds good. I can work on that.

xmnlab commented 4 years ago

maybe some PRs for release 1.3

2037

2034

2024

1964

scottcode commented 4 years ago

@xmnlab I just rebased and re-pushed #2024

xmnlab commented 4 years ago

@jreback maybe would be good to plan a new release for next week. what do you think ?

ian-r-rose commented 4 years ago

A release would be very appreciated!

jreback commented 4 years ago

ok this is what I think we need for the release.

@xmnlab you are volunteering as release manager? ok then

I think there are some instructions about how to release somewhere. when we are ready you should follow them (and update as you go if anything is unclear). It might be desirable to put the release scripts in something like this: https://github.com/pandas-dev/pandas-release (though ibis is relatively simple so may be overkill).

xmnlab commented 4 years ago

@jreback that sounds good. I will work on issue #2036 :) thanks!

xmnlab commented 4 years ago

hey everyone. another question for the next release. currently we have 4 backends as experimental: OmniSciDB, MySQL, Spark and Pandas.

what is the criteria to move from experimental to stable?

jreback commented 4 years ago

ok to move pandas to stable mysql not sure omnisci ? your call spark - @icexelloss

xmnlab commented 4 years ago

@jreback thanks for the answer. IMHO omnisci is stable at this point.

xmnlab commented 4 years ago

@icexelloss is spark already stable?

jreback commented 4 years ago

@xmnlab I think ok to start the release process. Please follow the instructions; if any changes pls add to the documentation later.

xmnlab commented 4 years ago

sounds great! I will work on that today! thanks @jreback !

icexelloss commented 4 years ago

Spark backend is still new and I prefer to keep it experimental.

icexelloss commented 4 years ago

I actually prefer not to move pandas to stable either, as there are some changes I am thinking about that might or might not break backward compatibility.

xmnlab commented 4 years ago

thanks for the information @icexelloss !

xmnlab commented 4 years ago

@jreback currently, according to the releasing documentation, we should use dev/genrelease.py and it will create create a release note for every PR merged. is it OK to mix that with the current release notes? if yes, should I add all release notes (bug, supp, feat)?

jreback commented 4 years ago

you can try that but will have to filter to avoid duplicated ones

xmnlab commented 4 years ago

@jreback I already created the tag. but it seems I don't have permission for uploading on pypi

HTTPError: 403 Client Error: The user 'xmnlab' isn't allowed to upload to project 'ibis-framework'.

could you give me permission to do that?

jreback commented 4 years ago

@xmnlab you need a pypi login (use the same username). once you have that ping me and will add you.

xmnlab commented 4 years ago

I already have one, the same name as on github: xmnlab, thanks!

jreback commented 4 years ago

ok, update PyPi; you should be able to upload now!

xmnlab commented 4 years ago

great! thanks! I will work on that.

xmnlab commented 4 years ago

done!

xmnlab commented 4 years ago

@jreback maybe would be good to write a twitter about the new Ibis release. Maybe we can use a template like https://twitter.com/ApacheArrow/status/1227634668700303361

Do you know who have access to Ibis twitter account?

let me know if I can help in any way.

jreback commented 4 years ago

start with an email to the mailing list

pls post a draft here

xmnlab commented 4 years ago

sounds good! I will work on that between today and tomorrow and I will post it here to be reviewed.

what mailing list do you have in mind?

xmnlab commented 4 years ago

text proposed:

We have released @IbisData 1.3.0 with 104 new contributions from 16 contributors. Read more about what's new at https://docs.ibis-project.org/release.html

PS:

xmnlab commented 4 years ago

@jreback any feedback?

jreback commented 4 years ago

look on pydata@googlegroups.com

for ANN subjects eg pandas 1.0.0

we can do something really simple

xmnlab commented 4 years ago

how about?

Hi all,

I'm pleased to announce that Ibis 1.3.0 is now available, after 8 months of development.

Highlights include

Renaming "mapd" backend to "omniscidb" Improvement of documentation, added new backends and geospatial methods to the documenation Improvement of geospatial support Addition of PySpark backend Addition of JSON, JSONB and UUID data types Support for Python 3.5 dropped. Initial support for Python 3.8 added.

For more details, check out the release page https://docs.ibis-project.org/release.html

The release can be installed from PyPI

python -m pip install --upgrade ibis-framework==1.3.0

Or from conda-forge

conda install ibis-framework=1.3.0 -c conda-forge
jreback commented 4 years ago

@xmnlab yep that looks good (just use bullet points for the highlites)

fire away

xmnlab commented 4 years ago

thanks! done!