search

ibis-project / ibis

the portable Python dataframe library
https://ibis-project.org
Apache License 2.0
5.02k stars 585 forks source link

string's .format() method breaks on {} without explicit positional argument in py2.6 #215

Closed laserson closed 9 years ago

laserson commented 9 years ago

Allowing empty "{}" for string formatting only works starting in python 2.7. Feel free to close this as "won't fix" if ibis is only targeting 2.7+

wesm commented 9 years ago

Yeah, only 2.7+

wesm commented 9 years ago

@laserson you think we should support 2.6?

laserson commented 9 years ago

Generally, yes, though not super strongly.

If we were talking about Spark, then for sure, bc it's easier to run PySpark on a node of the cluster, which may have CentOS 6, which defaults to 2.6. It's not as much of an issue with ibis, because we generally talk to the cluster through hiveserver2 and HDFS through WebHDFS. But it still may be convenient if there is a need to run on the cluster itself (maybe in Kerberized environments), and I don't think it would be too difficult to support 2.6

Let me know if you think we should do this and I can pick this issue up.

wesm commented 9 years ago

Cool, want to give 2.6 support a go? I don't think there are many 2.7+ features being used outside the string formattings tuff