search

ibis-project / ibis

the portable Python dataframe library
https://ibis-project.org
Apache License 2.0
4.3k stars 537 forks source link

fix(ir): ensure that schema column order matters #9068

Closed cpcloud closed 2 weeks ago

cpcloud commented 3 weeks ago

Ensure that column order is taken into account for equality comparisons. Fixes #9063.

cpcloud commented 2 weeks ago

Clouds are passing:

…/ibis on  schemas-are-ordered is 📦 v8.0.0 via 🐍 v3.12.2 via ❄️   impure (ibis-3.12.2-env) took 9s
❯ pytest -m 'bigquery or snowflake' -n auto --dist loadgroup --snapshot-update
======================================================================================== test session starts =========================================================================================
platform linux -- Python 3.12.2, pytest-8.1.1, pluggy-1.5.0
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
Using --randomly-seed=3621327880
rootdir: /home/cloud/src/ibis
configfile: pyproject.toml
plugins: anyio-4.3.0, xdist-3.5.0, pytest_httpserver-1.0.10, cov-5.0.0, timeout-2.3.1, benchmark-4.0.0, randomly-3.15.0, hypothesis-6.100.1, repeat-0.9.3, snapshot-0.9.0, mock-3.14.0, clarity-1.0.1
16 workers [3586 items]
..x.xx.xx...x....xx...x...............x.x..................x.x........x...........x.........x........x...........................................x.......x...........................x.....sss [  5%]
sssssssssssssssssssx....................................................x...........x........................................x..............x...................x................x..........x. [ 10%]
.............x.x...xxx.....xx....x..x.x.........x....xx....x......x......x....x....x.xx............xx.........x.x....x.....x................x....x............x.....................x..x...... [ 15%]
.x.x................x..x.........xx...........x..x.xx................x..x.................x....x..........x..............s...s............................................s.......x......s.... [ 21%]
...x............x....s.....xs............xx..s.x..............xxxx.x.xxx.xx..x.......x..x.........x......x....x....x......x........x.......xxx.x.xxxxx.xx.x.x..x..x..x...xx.x.x.xx.xxx...xxx.x [ 26%]
.xx...x.x.xx....x....x..xx.xx.x.x...x.....xx...x.......xx....................x........x..x.....s...x.....x.......x.....x..........x.............x..xx.xx..xxxxxxxxxxx.xxxxxxxxxxx.xxxx.xxxxx.x [ 31%]
xxxxxxxxxxxxxxx..xxxxxxxxxxxxxxxx.xxxxxxxxxxxxxxxx.xxxxxxxxxxx.xxxxxx.xxxx.xxxxxxxxx.xxxxxxx.x..x.x.x....xx....x.x..x..x........xx..x.x.......x..............................x.....xxx...x...x [ 37%]
x..........xx...................x............x....x......x....x..x.x.xx..x.xx..x...x..x.........x..............x....x.xx..xx.........x..x....x........x..x.........x....x..........xx......... [ 42%]
.....................x...x......xxx...................x......x.....x....x.........x......x..x...x.........x..xx..................x.x.......................x.............x.....x.............. [ 47%]
......x...xx.......x..xx......................................................x...........x.x......x............x.x..........x.............x..x........x..x...x.x.....xx......x......x.......x [ 52%]
..x.......x.x....x.........x.............x......x.....xx..........xx....x........x....x.x...x.........x........................x..........x.....x...............................x...x....x.... [ 58%]
.x...................................x.x....x.....................ss....................................................................................................s........x.xx......... [ 63%]
..s......x...xxxxxxx....x...xxx..x.x...x..x........x.....x......x...........x........xx....xxx.xxx.x.xxxxx.x......x...x...x.........x.x...x..........x......x.....x......x...........x.x...... [ 68%]
.s...x......x..........................x.......x.x.xxx....x........x.x..........x...x.....x.......x...x.x...x...s..xxxx.....x...x.x.xxxx.x..x..xx..x...xxxxx.xx.....xxxxx...x.x..xx.xx....x... [ 74%]
.xxxx.x.......x....xx...xxx.x..xxxxx.x...xxxx...x......x...x.....................x...........x..........xx.................x..........xx......x..x......................x.......xxx........... [ 79%]
...........x.....x......................x........x...x.x.xx.x...x.........x...................xx..x...x...x.........xx.....s...........................................x...................... [ 84%]
.............................................................................................................................................................................................. [ 90%]
...............................x................................................................................................x............................................................. [ 95%]
.................s..s.......................................................................................................x...........................x.............                         [100%]
===================================================================== 2978 passed, 39 skipped, 569 xfailed in 427.64s (0:07:07) ======================================================================
cpcloud commented 2 weeks ago

Closing in favor of #9081.