search

ibis-project / ibis

the portable Python dataframe library
https://ibis-project.org
Apache License 2.0
4.3k stars 537 forks source link

docs: update sankey diagram #9077

Closed lostmygithubaccount closed 2 weeks ago

lostmygithubaccount commented 2 weeks ago

Description of changes

this started as trying to get dynamic light/dark mode for plotting (with the sankey diagram, but any) working with Quarto. I still couldn't figure it out. there's definitely a path that's like save both versions of the image and use JavaScript to dynamically load the right one. another option, if we could get the HTML for the page in Python, would be to use that

so anyway, this actually just updates the sankey diagram to put it in a funciton to choose light/dark mode, minor code improvements, and improving the colors

one suggestion from Jim was simplifying the cateogires and I agree, so now it's just SQL/DataFrame

Issues closed

lostmygithubaccount commented 2 weeks ago

don't like the PNG, let me play with that

lostmygithubaccount commented 2 weeks ago

I like the colors and change to 2 categories, but it's way harder to read. going back to draft mode

lostmygithubaccount commented 2 weeks ago

it's better now IMO

ibis-docs-bot[bot] commented 2 weeks ago

Docs preview: https://pr-9077-e62cc76514ab576c480b48a7a090efffaf29d645--ibis-quarto.netlify.app