search

ibis-project / ibis

the portable Python dataframe library
https://ibis-project.org
Apache License 2.0
4.43k stars 544 forks source link

fix: convert the uint64's from some backends' hash() to the desired int64 #9136

Closed NickCrews closed 1 month ago

NickCrews commented 1 month ago

fixes https://github.com/ibis-project/ibis/issues/9135

I don't love the logic that does the conversion. It seems more complicated than it needs to be, and I don't like how I had to implement it once for each backend, but maybe there is no universal way to do this. If you can think of a cleaner way to do this or sidestep the need entirely that would be awesome

gforsyth commented 1 month ago

Hey @NickCrews -- I think the exasol failure is fixed on main if you want to rebase this

NickCrews commented 1 month ago

hey @gforsyth can you give this a review when you get the chance? Thanks!

NickCrews commented 1 month ago

@jcrist you all do the rebase and merge, right? Not squash?

jcrist commented 1 month ago

Depends on the commits and the desired changelog entries (multiple user facing changes would need multiple commits to note). Since this is only 1 commit and change, either works tbh.