search

ibitcy / eo-locale

🌏Internationalize React apps 👔Elegant lightweight library based on Internationalization API
https://eo-locale.netlify.com/
MIT License
348 stars 12 forks source link

Proposal about typings #7

Closed konstantin24121 closed 5 years ago

konstantin24121 commented 5 years ago

@pret-a-porter Max why you mark values as required arg in translator.formattMessage function? I think we can use this function without values)

this sting is annoying

translator.formatMessage('__APP__::VERIFICATION_DIALOG::PHONE_CODE', {})

https://github.com/ibitcy/eo-locale/blob/master/src/utils/translator.ts#L42

What do you think? I can fix it, if you are agree with proposal

konstantin24121 commented 5 years ago

@pret-a-porter sorry, confused between format and translate functions