search

ibitcy / react-native-hole-view

✂️ React-Native component to cut a touch-through holes anywhere you want. Perfect solution for tutorial overlay
364 stars 20 forks source link

Not compatible with Expo 44 #12

Closed kristfal closed 2 years ago

kristfal commented 2 years ago

Hey,

we just upgraded to Expo 44 in our ejected app and noticed an iOS build issue with this library. Fix is similar to https://github.com/expo/expo/pull/15626

Here is the diff for this package:

diff --git a/node_modules/react-native-hole-view/ios/src/RNHoleViewManager.h b/node_modules/react-native-hole-view/ios/src/RNHoleViewManager.h
index 124e29c..b18377a 100644
--- a/node_modules/react-native-hole-view/ios/src/RNHoleViewManager.h
+++ b/node_modules/react-native-hole-view/ios/src/RNHoleViewManager.h
@@ -7,11 +7,7 @@
 //

 #import <Foundation/Foundation.h>
-#if __has_include("RCTBridgeModule.h")
-#import "RCTBridgeModule.h"
-#else
 #import <React/RCTBridgeModule.h>
-#endif

 #import <React/RCTViewManager.h>
stephenkopylov commented 2 years ago

Hey @kristfal thank you for suggestion!

Please check out v2.1.0

stephenkopylov commented 2 years ago

Closing due to inactivity

@kristfal if you still face the issue - feel free to reopen it