search

ibitcy / react-native-hole-view

✂️ React-Native component to cut a touch-through holes anywhere you want. Perfect solution for tutorial overlay
364 stars 20 forks source link

Gradle plugin deprecated #20

Closed vikrantnegi closed 1 year ago

vikrantnegi commented 1 year ago

Hi, I'm getting warning when trying to upgrade my gradle in Android.

The 'kotlin-android-extensions' Gradle plugin is deprecated. Please use this migration guide (https://goo.gle/kotlin-android-extensions-deprecation) to start working with View Binding (https://developer.android.com/topic/libraries/view-binding) and the 'kotlin-parcelize' plugin.

stephenkopylov commented 1 year ago

Hi @vikrantnegi

Sorry, but we're not going to make a migration only because of warnings - RN itself and lots of it's libraries are full of warnings

But if you'd like to migrate the library to View Binding - feel free to make a PR

vikrantnegi commented 1 year ago

Hi @stephenkopylov

'kotlin-android-extensions' plugin is used for synthetic properties and since we are not using any, it is mainly unused. So it is safe to remove this which in turn will help with the warning.

ManeeshBusi commented 1 year ago

Hey @stephenkopylov, I just installed the package on a new project and i've been getting the same error. It's preventing me from building the app and running it. Is there a workaround for this issue or is it something from my end?

stephenkopylov commented 1 year ago

Hi again guys! The issue should be fixed in v2.2.1 Please take a look :)

PS: @vikrantnegi thanks for your advice!