search

ibitcy / react-native-hole-view

✂️ React-Native component to cut a touch-through holes anywhere you want. Perfect solution for tutorial overlay
364 stars 20 forks source link

Support for new architecture #21

Closed zabojad closed 1 year ago

zabojad commented 1 year ago

Hi there! Am I wrong or does this module not support the new architecture (Fabric) ?

zabojad commented 1 year ago

https://github.com/ibitcy/react-native-hole-view/pull/22

ronlobo01 commented 1 year ago

@zabojad are you facing this issue > Task :react-native-hole-view:compileReleaseKotlin FAILED while generating build.

Is your issue related to this ?

zabojad commented 1 year ago

@ronlobo01 No, I'm not. And no, it's probably not related... My work compiles on Android both with and without new arch...

zabojad commented 1 year ago

FYI the PR is now fully functional on Android (both new and old architecture)

stephenkopylov commented 1 year ago

@zabojad done

Thanks a lot for contributing!