search

ibitcy / react-native-hole-view

✂️ React-Native component to cut a touch-through holes anywhere you want. Perfect solution for tutorial overlay
395 stars 23 forks source link

rerendering, going from 1 hole, to no holes doesn't seem to erase the old hole #26

Open dcorbin opened 10 months ago

dcorbin commented 10 months ago

I have situation where I start out with 0 holes, add 1 hole that changes multiple times, and then (through a bug) goes back to 0 holes. At this last stage, passing the empty array of holes does not eliminate the hole from the previous stage. As a workaround, I can create a hole with 0 width/height and that does just fine.

stephenkopylov commented 10 months ago

@dcorbin thanks for bug report! It would be really helpful if you'd have created small example app (for example using create-react-native-app) demonstrating this behaviour - we'll try to fix it as soon as possible

dcorbin commented 10 months ago

https://github.com/dcorbin/RNHoleViewBug. Sample App.