search

ibitcy / react-native-hole-view

✂️ React-Native component to cut a touch-through holes anywhere you want. Perfect solution for tutorial overlay
395 stars 23 forks source link

Compilation failure, Android with RN 0.73.1 #30

Closed dcorbin closed 8 months ago

dcorbin commented 9 months ago

/react_native_hole_view/RNHoleView.kt:179:5 'onDraw' overrides nothing

I'm upgrading my project's version of React Native from 0.72.8 to 0.73.1. Now the Android build fails with the above error, near as I can tell. I presume this is a result of the introduction of Bridgeless Mode that happen in 0.73. Is it possible to enable new architecture and Fabric in this project?

dcorbin commented 9 months ago

1) Create a new React project: npx react-native init project 2) add react-native-hole-view to the project: yarn add react-native-hole-view 3) Run the project on Android: npx react-native run-android

Sample Repo: https://github.com/dcorbin/rnhv_compile_bug_RN0.73.1

dcorbin commented 9 months ago

I've determined that this is a problem because of android SDK 34. When I roll back to 33, it works fine. (But new RN projects are made with 34).

luicfrr commented 8 months ago

+1

stephenkopylov commented 8 months ago

@dcorbin please check out v3.0.0-alpha4

dcorbin commented 8 months ago

I can confirm that the problem is fixed in 3.0.0-alpha4

Thanks much.