High FDR in ORA - Githubissues

iblacksand / WebGestaltR

R package for WebGestalt

https://iblacksand.github.io/WebGestaltR/

0 stars 0 forks source link

High FDR in ORA #2

Closed iblacksand closed 9 months ago

iblacksand commented 9 months ago

The FDRs calculated in the Rust library is consistently higher than the R library, but not by a high amount. GSEA FDRs are also higher, but not by as much as ORA. The high FDR has caused some problems, such as #1.

Progress

[x] Investigate why the adjustp crate calculates high FDR
[x] Determine if we should implement FDR calculations ourselves
- Would allow for less crates being downloaded

iblacksand commented 9 months ago

Fixed in a97f550 by filtering gene set before sending to Rust, and having the Rust package not filter further.