Changed more things. - Githubissues

iblobtouch / iblobtouch.github.io

35 stars 47 forks source link

Changed more things. #33

Closed ericw31415 closed 7 years ago

ericw31415 commented 7 years ago

Added message for no JavaScript and better tooltips.

Acarii commented 7 years ago

~~Not seeing any issues with this~~. Hell, you're doing things I was wondering how to do myself. I'll probably tweak/play with your colour choices again, but this is good.

Noted issue(s):

Tooltips are half broken. data-tooltips does not seem to like anything not an <span>

I may merge anyhow, then temporarily overwrite the broken parts with the old system.

ericw31415 commented 7 years ago

When you say data-tooltip is broken, do you mean you were experimenting with it yourself? A data- attribute is a custom attribute in HTML. I made all the tags with class="info" have a tooltip with the value of the data-tooltip attribute. If you don't add that class, then it won't work.

You may also wish to review my CSS for .info {}....