search

ibm-bluemix-mobile-services / bms-clientsdk-android-core

Core components of Bluemix Mobile Services Android SDK
Apache License 2.0
6 stars 11 forks source link

Removed usage of internal parts of the OkHttp3. #71

Closed tavar closed 4 years ago

tavar commented 4 years ago

Replaced the calls of internals with direct interaction with the Android SDK without OkHttp in the middle. Allow updating to newer versions of OkHttp.

Fixes #70

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 25.49% when pulling 967c4c41812a092f85419865fc0c53df7afcf4fc on tavar:removedInternalPartsOfOkHttp into 8db4f00d0d564792397bfc0e5bd57d52a238b858 on ibm-bluemix-mobile-services:master.

AnanthaKrish commented 4 years ago

@tavar Merging the code to development branch . After testing will release a new version. Thank you.

Sadhvi-Nayak commented 4 years ago

@AnanthaKrish Is this in new version? facing this issue for push notification service.

java.lang.NoSuchFieldError: No static field UTF_8 of type Ljava/nio/charset/Charset; in class Lokhttp3/internal/Util; or its superclasses (declaration of 'okhttp3.internal.Util' appears in /data/app/<app>==/base.apk)
07-02 21:12:20.652 25962 26056 E AndroidRuntime:    at com.ibm.mobilefirstplatform.clientsdk.android.core.internal.ResponseImpl.getResponseText(ResponseImpl.java:120)
07-02 21:12:20.652 25962 26056 E AndroidRuntime:    at com.ibm.mobilefirstplatform.clientsdk.android.core.internal.ResponseImpl.toString(ResponseImpl.java:267)
07-02 21:12:20.652 25962 26056 E AndroidRuntime:    at com.ibm.mobilefirstplatform.clientsdk.android.push.internal.MFPPushInvoker.onSuccess(MFPPushInvoker.java:97)
07-02 21:12:20.652 25962 26056 E AndroidRuntime:    at com.ibm.mobilefirstplatform.clientsdk.android.core.api.Request$1.onResponse(Request.java:467)
07-02 21:12:20.652 25962 26056 E AndroidRuntime:    at okhttp3.RealCall$AsyncCall.execute(RealCall.java:174)
07-02 21:12:20.652 25962 26056 E AndroidRuntime:    at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
07-02 21:12:20.652 25962 26056 E AndroidRuntime:    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
07-02 21:12:20.652 25962 26056 E AndroidRuntime:    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
07-02 21:12:20.652 25962 26056 E AndroidRuntime:    at java.lang.Thread.run(Thread.java:919)