ibm-bluemix-mobile-services / bms-clientsdk-android-push

Android Push notifications SDK for IBM Cloud Mobile Services
Apache License 2.0
10 stars 12 forks source link

Custom Icon Error #115

Closed Daiki-Kawanuma closed 5 years ago

Daiki-Kawanuma commented 6 years ago

Hi, team.

I couldn't set my custom icon. I think this code is wrong.

MFPPushIntentService

resourceId = context.getResources().getIdentifier(DRAWABLE+"/" + resourceName, DRAWABLE, context.getPackageName());

Fix to ...

resourceId = context.getResources().getIdentifier(resourceName, DRAWABLE, context.getPackageName());

(As a premise, we have to deploy the custom icon to drawable/push_notification_icon.png.)

What do you think?

AnanthaKrish commented 6 years ago

@Daiki-Kawanuma Hi, Thanks for pointing out the suggestion . I will make the change ASAP, and will let you know once the new SDK is out . 👍