search

ibm-bluemix-mobile-services / bms-clientsdk-android-push

Android Push notifications SDK for IBM Cloud Mobile Services
Apache License 2.0
10 stars 12 forks source link

Change dependency to just GCM instead of all of the play services. #17

Closed dgonz7 closed 8 years ago

dgonz7 commented 8 years ago

Having the full Play Services SDK is a bad idea, since it is huge. This causes two issues: first, it makes compilation take much longer, and also causes dex limit issues since there are so many methods, making it pretty close to the 65,536 method count limit. This pull request simply changes the dependency from the full SDK to just the GCM SDK and its dependencies. It compiles correctly and all the tests pass, so it should be ok.

I am doing this in response to this issue: https://github.com/ibm-bluemix-mobile-services/bms-clientsdk-android-core/issues/13.

jekiapp commented 8 years ago

is it gonna take long time to be available on maven? if yes, I better compile it manually from here. thanks